This doesn't seem like a quick fix. So it will take a bit of time to get this working properly.
I might need to have to rewrite an entire part of the approach.
So don't expect a fixed version before Thursday. Sorry about this...
Could you confirm the upgrade process please. I have tried installing the dev release on an already upgraded website and it hasn't fixed the issue.
Does the J3 dev version need to be installed on J3, prior to upgrade? Followed by installing the J4 dev version on the J4 site after upgrade? Or should the dev release have fixed the problem on the existing site?
I have a large site upgrade to do this weekend, with several hundred modules and I don’t have the option of deferring the upgrade. Would you recommend installing the J4 dev version, so conditions are migrated correctly and then install the current J4 production version over the top. Or staying with the J4 dev version until it’s officially released, which I’m guessing will be pretty soon?
I know ideally it would be better to wait for the official release, but unfortunately put off the upgrade isn’t an option and time wise, it would be very tight to manually configure all the modules.
We've just finished testing a new test instance and can confirm that the latest dev version seems to successfully convert all menu assignments into conditions. (this was with 9.1.3PRO-dev2335180)
Nice work!
Looking forward to having this fix be official.
That being said, I did find a bug (seemingly unrelated to the conversion process), so I'll open a new thread for that.
Thank you so much for that fix, it is working pretty well but I have noticed one problem so far. It does not seem to be converting the "Page Type" check boxes under Matching Method Categories. So even though the correct categories are checked it still isn't showing up because the box "Categories" or "Article" are not being checked.
Let me know if you need anything from me while you work on that.